Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): share page show 404 #9083

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Dec 10, 2024

No description provided.

Copy link

graphite-app bot commented Dec 10, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@EYHN EYHN marked this pull request as ready for review December 10, 2024 06:28
Copy link
Member Author

EYHN commented Dec 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

nx-cloud bot commented Dec 10, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 18d65df. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.14%. Comparing base (ffad115) to head (18d65df).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9083      +/-   ##
==========================================
+ Coverage   65.57%   66.14%   +0.56%     
==========================================
  Files         713      713              
  Lines       40714    40714              
  Branches     3930     3967      +37     
==========================================
+ Hits        26700    26930     +230     
+ Misses      13599    13366     -233     
- Partials      415      418       +3     
Flag Coverage Δ
server-test 78.34% <ø> (+0.71%) ⬆️
unittest 35.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/fix/share-page-404 branch from 5886bc0 to 1c3bf59 Compare December 10, 2024 06:42
@github-actions github-actions bot added the test Related to test cases label Dec 10, 2024
Copy link

graphite-app bot commented Dec 10, 2024

Merge activity

EYHN added a commit that referenced this pull request Dec 10, 2024
@EYHN EYHN force-pushed the eyhn/fix/share-page-404 branch from 1c3bf59 to cab3d45 Compare December 10, 2024 07:20
EYHN added a commit that referenced this pull request Dec 10, 2024
@EYHN EYHN force-pushed the eyhn/fix/share-page-404 branch from cab3d45 to a9dbc56 Compare December 10, 2024 07:37
@EYHN EYHN force-pushed the eyhn/fix/share-page-404 branch from a9dbc56 to 18d65df Compare December 10, 2024 07:43
@graphite-app graphite-app bot merged commit 18d65df into canary Dec 10, 2024
47 checks passed
@graphite-app graphite-app bot deleted the eyhn/fix/share-page-404 branch December 10, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants