Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): at menu ux #9045

Merged
merged 1 commit into from
Dec 6, 2024
Merged

feat(core): at menu ux #9045

merged 1 commit into from
Dec 6, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Dec 6, 2024

fix AF-1843

Copy link

graphite-app bot commented Dec 6, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added mod:i18n Related to i18n app:core labels Dec 6, 2024
Copy link
Collaborator Author

pengx17 commented Dec 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pengx17 pengx17 marked this pull request as ready for review December 6, 2024 07:01
Copy link

nx-cloud bot commented Dec 6, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b378af5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.43%. Comparing base (d6869ca) to head (b378af5).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...d/core/src/modules/journal/suggest-journal-date.ts 94.28% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9045      +/-   ##
==========================================
+ Coverage   65.26%   65.43%   +0.16%     
==========================================
  Files         675      676       +1     
  Lines       38797    38694     -103     
  Branches     3673     3651      -22     
==========================================
- Hits        25322    25320       -2     
+ Misses      13102    13001     -101     
  Partials      373      373              
Flag Coverage Δ
server-test 77.38% <ø> (ø)
unittest 34.75% <95.45%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 12-06-feat_core_at_menu_ux branch from 15caa43 to 71dd9d0 Compare December 6, 2024 07:42
@github-actions github-actions bot added the test Related to test cases label Dec 6, 2024
@pengx17 pengx17 force-pushed the 12-06-feat_core_at_menu_ux branch from 71dd9d0 to 337ce1f Compare December 6, 2024 07:43
Copy link

graphite-app bot commented Dec 6, 2024

Merge activity

@pengx17 pengx17 force-pushed the 12-06-feat_core_at_menu_ux branch from 337ce1f to b378af5 Compare December 6, 2024 08:50
@graphite-app graphite-app bot merged commit b378af5 into canary Dec 6, 2024
46 checks passed
@graphite-app graphite-app bot deleted the 12-06-feat_core_at_menu_ux branch December 6, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants