Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): impl team workspace #9026

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Dec 5, 2024

No description provided.

Copy link

graphite-app bot commented Dec 5, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

JimmFly commented Dec 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

nx-cloud bot commented Dec 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a8b0459. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 65.04%. Comparing base (888a9ac) to head (a8b0459).
Report is 5 commits behind head on jimmfly/1125/feat-team-ui.

Files with missing lines Patch % Lines
.../server/src/core/workspaces/resolvers/workspace.ts 40.00% 9 Missing ⚠️
...nd/core/src/modules/cloud/entities/subscription.ts 0.00% 2 Missing ⚠️
.../src/modules/cloud/entities/subscription-prices.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           jimmfly/1125/feat-team-ui    #9026      +/-   ##
=============================================================
- Coverage                      65.06%   65.04%   -0.02%     
=============================================================
  Files                            678      678              
  Lines                          39525    39545      +20     
  Branches                        3731     3733       +2     
=============================================================
+ Hits                           25715    25723       +8     
- Misses                         13435    13447      +12     
  Partials                         375      375              
Flag Coverage Δ
server-test 76.77% <40.00%> (-0.02%) ⬇️
unittest 34.47% <40.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly changed the title feat(server): add getIsAdmin function feat(core): impl Team Workspace Dec 5, 2024
@JimmFly JimmFly changed the title feat(core): impl Team Workspace feat(core): impl team workspace Dec 5, 2024
@JimmFly JimmFly force-pushed the jimmfly/1125/feat-team-ui branch from 38583eb to cb737a4 Compare December 5, 2024 06:37
@JimmFly JimmFly force-pushed the jimmfly/1205/team-frontend branch from 3fc1415 to 43deed3 Compare December 5, 2024 06:38
@github-actions github-actions bot added the mod:i18n Related to i18n label Dec 5, 2024
@JimmFly JimmFly force-pushed the jimmfly/1125/feat-team-ui branch from cb737a4 to dc11130 Compare December 5, 2024 08:41
@JimmFly JimmFly force-pushed the jimmfly/1205/team-frontend branch from 43deed3 to 8825da4 Compare December 5, 2024 08:42
@JimmFly JimmFly force-pushed the jimmfly/1125/feat-team-ui branch from dc11130 to 27dc8b6 Compare December 5, 2024 13:47
@JimmFly JimmFly force-pushed the jimmfly/1205/team-frontend branch from 58d1a5e to 475c2c5 Compare December 5, 2024 16:38
@github-actions github-actions bot added the mod:infra Environment related issues and discussions label Dec 5, 2024
@JimmFly JimmFly force-pushed the jimmfly/1205/team-frontend branch from 9d859e3 to 78646d6 Compare December 6, 2024 00:44
@JimmFly JimmFly marked this pull request as ready for review December 6, 2024 00:44
@JimmFly JimmFly force-pushed the jimmfly/1205/team-frontend branch from 78646d6 to a8b0459 Compare December 6, 2024 00:55
@JimmFly JimmFly merged commit a8b0459 into jimmfly/1125/feat-team-ui Dec 6, 2024
42 of 45 checks passed
@JimmFly JimmFly deleted the jimmfly/1205/team-frontend branch December 6, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:server mod:component mod:i18n Related to i18n mod:infra Environment related issues and discussions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant