Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): lit portal rerender #9012

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Dec 4, 2024

No description provided.

Copy link

graphite-app bot commented Dec 4, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@pengx17 pengx17 marked this pull request as ready for review December 4, 2024 05:08
Copy link
Collaborator Author

pengx17 commented Dec 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

nx-cloud bot commented Dec 4, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit dddefcf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 64.66%. Comparing base (b637a62) to head (dddefcf).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...component/src/lit-react/lit-portal/lite-portal.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9012      +/-   ##
==========================================
- Coverage   64.66%   64.66%   -0.01%     
==========================================
  Files         669      669              
  Lines       37423    37424       +1     
  Branches     3621     3622       +1     
==========================================
  Hits        24199    24199              
- Misses      12854    12855       +1     
  Partials      370      370              
Flag Coverage Δ
server-test 77.14% <ø> (ø)
unittest 34.44% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 12-04-fix_core_lit_portal_rerender branch from 6696462 to dddefcf Compare December 4, 2024 06:20
@graphite-app graphite-app bot merged commit dddefcf into canary Dec 4, 2024
46 checks passed
Copy link

graphite-app bot commented Dec 4, 2024

Merge activity

@graphite-app graphite-app bot deleted the 12-04-fix_core_lit_portal_rerender branch December 4, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants