Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): at menu journal entries (#8877) #8935

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Nov 27, 2024

fix AF-1790
fix AF-1774
added DateSelectorDialog for selecting a date through blocksuite;
added AtMenuConfigService for constructing the at menu config
fix AF-1776
fix PD-1942

resubmitted to replace #8877

Copy link

graphite-app bot commented Nov 27, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Nov 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added mod:i18n Related to i18n mod:dev test Related to test cases app:core labels Nov 27, 2024
@pengx17 pengx17 marked this pull request as ready for review November 27, 2024 02:52
Copy link

nx-cloud bot commented Nov 27, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 83c587f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 27.43902% with 119 lines in your changes missing coverage. Please review.

Project coverage is 64.89%. Comparing base (e3a8f1e) to head (83c587f).
Report is 5 commits behind head on canary.

Files with missing lines Patch % Lines
.../core/src/modules/at-menu-config/services/index.ts 29.93% 102 Missing and 1 partial ⚠️
...ntend/core/src/modules/journal/services/journal.ts 5.88% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8935      +/-   ##
==========================================
- Coverage   70.54%   64.89%   -5.65%     
==========================================
  Files         544      659     +115     
  Lines       33772    37311    +3539     
  Branches     3008     3596     +588     
==========================================
+ Hits        23823    24213     +390     
- Misses       9585    12730    +3145     
- Partials      364      368       +4     
Flag Coverage Δ
server-test 77.13% <ø> (ø)
unittest 35.01% <27.43%> (-11.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Nov 27, 2024

Merge activity

fix AF-1790
fix AF-1774
added `DateSelectorDialog` for selecting a date through blocksuite;
added `AtMenuConfigService` for constructing the at menu config
fix AF-1776
fix PD-1942

resubmitted to replace #8877
@pengx17 pengx17 force-pushed the xp/feat/11-20-at-menu-journals branch from ddf5b5f to 83c587f Compare November 27, 2024 03:08
@graphite-app graphite-app bot merged commit 83c587f into canary Nov 27, 2024
46 checks passed
@graphite-app graphite-app bot deleted the xp/feat/11-20-at-menu-journals branch November 27, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:dev mod:i18n Related to i18n test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants