Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): improve doc meta performance #8913

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Nov 25, 2024

No description provided.

Copy link

graphite-app bot commented Nov 25, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@EYHN EYHN marked this pull request as ready for review November 25, 2024 06:44
@graphite-app graphite-app bot requested review from forehalo, JimmFly, CatsJuice and pengx17 and removed request for CatsJuice November 25, 2024 06:44
Copy link
Member Author

EYHN commented Nov 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the mod:infra Environment related issues and discussions label Nov 25, 2024
Copy link

nx-cloud bot commented Nov 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e85ff4d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 70.17%. Comparing base (b369ee0) to head (e85ff4d).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...ckages/common/infra/src/modules/doc/stores/docs.ts 0.00% 13 Missing ⚠️
...mmon/infra/src/modules/doc/entities/record-list.ts 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8913      +/-   ##
==========================================
- Coverage   70.24%   70.17%   -0.08%     
==========================================
  Files         551      551              
  Lines       34014    34022       +8     
  Branches     3053     3055       +2     
==========================================
- Hits        23894    23874      -20     
- Misses       9748     9776      +28     
  Partials      372      372              
Flag Coverage Δ
server-test 77.07% <ø> (-0.07%) ⬇️
unittest 46.01% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

meta.forEach(doc => {
if (doc.get('id') === id) {
docMetaYMap = doc;
if (docMetaIndexCache >= 0) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will the index change when any page is permanently removed from workspace meta?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod:infra Environment related issues and discussions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants