Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): update prompt texts for opening new doc #8696

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Nov 4, 2024

fix AF-1590

Copy link

graphite-app bot commented Nov 4, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Nov 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Nov 4, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e7732d0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.12%. Comparing base (8c650f7) to head (e7732d0).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8696      +/-   ##
==========================================
+ Coverage   70.06%   70.12%   +0.05%     
==========================================
  Files         546      546              
  Lines       33809    33809              
  Branches     3055     3055              
==========================================
+ Hits        23687    23707      +20     
+ Misses       9761     9741      -20     
  Partials      361      361              
Flag Coverage Δ
server-test 77.18% <ø> (+0.06%) ⬆️
unittest 44.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 11-04-test_core_add_open_in_app_test_case branch from 9e80885 to c3d2563 Compare November 5, 2024 03:10
@pengx17 pengx17 force-pushed the 11-04-fix_core_update_prompt_texts_for_opening_new_doc branch from a655e6a to ff84169 Compare November 5, 2024 03:10
Copy link

graphite-app bot commented Nov 5, 2024

Merge activity

@forehalo forehalo force-pushed the 11-04-test_core_add_open_in_app_test_case branch from c3d2563 to 8c650f7 Compare November 5, 2024 07:31
@forehalo forehalo force-pushed the 11-04-fix_core_update_prompt_texts_for_opening_new_doc branch from ff84169 to e7732d0 Compare November 5, 2024 07:31
Base automatically changed from 11-04-test_core_add_open_in_app_test_case to canary November 5, 2024 07:46
@graphite-app graphite-app bot merged commit e7732d0 into canary Nov 5, 2024
46 checks passed
@graphite-app graphite-app bot deleted the 11-04-fix_core_update_prompt_texts_for_opening_new_doc branch November 5, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants