Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): handle hanging workspace after user account deleted #8377

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

forehalo
Copy link
Member

@forehalo forehalo commented Sep 24, 2024

fix CLOUD-74

Copy link

graphite-app bot commented Sep 24, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @forehalo and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Sep 24, 2024

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 86.84211% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.75%. Comparing base (d0050a2) to head (1d75d97).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
.../backend/server/src/core/doc/adapters/workspace.ts 83.33% 2 Missing ⚠️
packages/backend/server/src/core/doc/job.ts 85.71% 2 Missing ⚠️
.../server/src/core/workspaces/resolvers/workspace.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8377      +/-   ##
==========================================
+ Coverage   72.67%   72.75%   +0.07%     
==========================================
  Files         520      520              
  Lines       32924    32947      +23     
  Branches     2871     2875       +4     
==========================================
+ Hits        23929    23970      +41     
+ Misses       8964     8946      -18     
  Partials       31       31              
Flag Coverage Δ
server-test 78.97% <86.84%> (+0.08%) ⬆️
unittest 49.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forehalo forehalo force-pushed the 61/user-deleted branch 2 times, most recently from 94c6d71 to e3a92ee Compare September 25, 2024 03:24
Copy link

graphite-app bot commented Sep 25, 2024

Merge activity

@graphite-app graphite-app bot merged commit 1d75d97 into canary Sep 25, 2024
38 checks passed
@graphite-app graphite-app bot deleted the 61/user-deleted branch September 25, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants