Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): enable WAL mode for sqlite #8336

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Sep 20, 2024

fix AF-1015

Copy link

graphite-app bot commented Sep 20, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Sep 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Sep 20, 2024

@pengx17 pengx17 force-pushed the xp/09-20-fix_electron_enable_wal_mode_for_sqlite branch from b48c412 to 2ff73a8 Compare September 20, 2024 10:56
@pengx17 pengx17 changed the base branch from xp/09-20-fix_core_correctly_ensure_properties_in_pagepropertiesmetamanager to canary September 20, 2024 10:56
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 72.73%. Comparing base (e6feb17) to head (e839947).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...frontend/apps/electron/src/helper/db/db-adapter.ts 0.00% 6 Missing ⚠️
...pps/electron/src/helper/db/workspace-db-adapter.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8336      +/-   ##
==========================================
- Coverage   72.74%   72.73%   -0.02%     
==========================================
  Files         520      520              
  Lines       32916    32923       +7     
  Branches     2869     2870       +1     
==========================================
  Hits        23946    23946              
- Misses       8939     8946       +7     
  Partials       31       31              
Flag Coverage Δ
server-test 78.95% <ø> (ø)
unittest 49.59% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the xp/09-20-fix_electron_enable_wal_mode_for_sqlite branch from 2ff73a8 to af5a1b3 Compare September 23, 2024 08:15
@pengx17 pengx17 force-pushed the xp/09-20-fix_electron_enable_wal_mode_for_sqlite branch 4 times, most recently from 6d5d9ca to 0b003a8 Compare September 25, 2024 03:21
@github-actions github-actions bot added the app:electron Related to electron app label Sep 25, 2024
Copy link

graphite-app bot commented Sep 25, 2024

Merge activity

@pengx17 pengx17 force-pushed the xp/09-20-fix_electron_enable_wal_mode_for_sqlite branch from 0b003a8 to e839947 Compare September 25, 2024 04:06
@graphite-app graphite-app bot merged commit e839947 into canary Sep 25, 2024
38 checks passed
@graphite-app graphite-app bot deleted the xp/09-20-fix_electron_enable_wal_mode_for_sqlite branch September 25, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app mod:native rust
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants