Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): allow switch workspace in loading fallback #6129

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Mar 15, 2024

No description provided.

Copy link

graphite-app bot commented Mar 15, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@EYHN EYHN marked this pull request as ready for review March 15, 2024 03:04
Copy link
Member Author

EYHN commented Mar 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Mar 15, 2024

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 60.48%. Comparing base (96c67af) to head (12c04a8).

Files Patch % Lines
...d/core/src/components/workspace-selector/index.tsx 16.66% 5 Missing ⚠️
...frontend/core/src/components/app-sidebar/index.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6129      +/-   ##
==========================================
- Coverage   61.00%   60.48%   -0.52%     
==========================================
  Files         488      496       +8     
  Lines       22181    22457     +276     
  Branches     1939     2004      +65     
==========================================
+ Hits        13531    13584      +53     
- Misses       8422     8644     +222     
- Partials      228      229       +1     
Flag Coverage Δ
server-test 70.17% <ø> (-0.01%) ⬇️
unittest 39.62% <12.50%> (-0.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Mar 15, 2024

Merge activity

@EYHN EYHN force-pushed the eyhn/fix/catch-auth-error branch from 9b7c607 to 96c67af Compare March 15, 2024 03:46
@EYHN EYHN force-pushed the eyhn/feat/fallback branch from 8f274ad to 12c04a8 Compare March 15, 2024 03:47
@EYHN EYHN changed the base branch from eyhn/fix/catch-auth-error to canary March 15, 2024 03:58
@graphite-app graphite-app bot merged commit 12c04a8 into canary Mar 15, 2024
34 checks passed
@graphite-app graphite-app bot deleted the eyhn/feat/fallback branch March 15, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants