Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): cleanup gateway code #6118

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

forehalo
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Mar 14, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

forehalo commented Mar 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @forehalo and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Mar 14, 2024

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 18.24818% with 112 lines in your changes are missing coverage. Please review.

Project coverage is 61.07%. Comparing base (79ffca3) to head (533c181).

Files Patch % Lines
...kend/server/src/core/sync/events/events.gateway.ts 11.88% 89 Missing ⚠️
...s/backend/server/src/core/workspaces/permission.ts 22.72% 17 Missing ⚠️
...ges/frontend/workspace-impl/src/cloud/awareness.ts 0.00% 4 Missing ⚠️
packages/frontend/workspace-impl/src/cloud/sync.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6118      +/-   ##
==========================================
+ Coverage   60.90%   61.07%   +0.17%     
==========================================
  Files         488      488              
  Lines       22200    22181      -19     
  Branches     1943     1940       -3     
==========================================
+ Hits        13520    13548      +28     
+ Misses       8451     8404      -47     
  Partials      229      229              
Flag Coverage Δ
server-test 70.29% <19.08%> (+0.28%) ⬆️
unittest 40.43% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forehalo forehalo force-pushed the 61/ultra-fast-sync branch from 64728d6 to 28711e5 Compare March 14, 2024 10:16
@forehalo forehalo force-pushed the 61/clean-websocket-gateway branch from e00d339 to 2ae9421 Compare March 14, 2024 10:16
@darkskygit darkskygit changed the base branch from 61/ultra-fast-sync to canary March 14, 2024 17:44
@forehalo forehalo force-pushed the 61/clean-websocket-gateway branch from 2ae9421 to 3c52a3e Compare March 15, 2024 01:50
Copy link

graphite-app bot commented Mar 15, 2024

Merge activity

@forehalo forehalo force-pushed the 61/clean-websocket-gateway branch from 3c52a3e to 533c181 Compare March 15, 2024 02:01
@graphite-app graphite-app bot merged commit 533c181 into canary Mar 15, 2024
38 of 42 checks passed
@graphite-app graphite-app bot deleted the 61/clean-websocket-gateway branch March 15, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants