Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): shared page's present button not working #6117

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

CatsJuice
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Mar 14, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

@CatsJuice CatsJuice changed the title fix(core): shared page'e present button not working fix(core): shared page's present button not working Mar 14, 2024
@CatsJuice CatsJuice marked this pull request as ready for review March 14, 2024 08:45
Copy link

nx-cloud bot commented Mar 14, 2024

@CatsJuice CatsJuice force-pushed the catsjuice/fix/share-page-presentation branch from cbe2708 to 1d41483 Compare March 14, 2024 08:46
@CatsJuice CatsJuice requested review from EYHN, JimmFly and pengx17 March 14, 2024 08:48
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.99%. Comparing base (e35f6dc) to head (ee75b46).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6117      +/-   ##
==========================================
- Coverage   61.02%   60.99%   -0.03%     
==========================================
  Files         487      488       +1     
  Lines       22180    22181       +1     
  Branches     1939     1939              
==========================================
- Hits        13536    13530       -6     
- Misses       8416     8422       +6     
- Partials      228      229       +1     
Flag Coverage Δ
server-test 70.17% <ø> (-0.01%) ⬇️
unittest 40.43% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice force-pushed the catsjuice/fix/share-page-presentation branch from 1d41483 to 50f5c4a Compare March 14, 2024 08:51
Copy link

graphite-app bot commented Mar 15, 2024

Merge activity

@EYHN EYHN force-pushed the catsjuice/fix/share-page-presentation branch from 50f5c4a to ee75b46 Compare March 15, 2024 03:32
@graphite-app graphite-app bot merged commit ee75b46 into canary Mar 15, 2024
38 of 42 checks passed
@graphite-app graphite-app bot deleted the catsjuice/fix/share-page-presentation branch March 15, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants