feat: improve validators for captcha

packages/backend/server/src/core/utils/__tests__/validators.spec.ts

@@ -0,0 +1,44 @@
+import test from 'ava';
+
+import { validators } from '../validators';
+
+test('can validate', t => {
+  t.notThrows(() => validators.assertValidEmail('[email protected]'));
+  t.throws(() => validators.assertValidEmail('test@example'));
+  t.throws(() => validators.assertValidEmail('test'));
+
+  t.notThrows(() => validators.assertValidPassword('password'));
+  t.notThrows(() => validators.assertValidPassword('a'));
+  t.throws(() => validators.assertValidPassword(''));
+  t.throws(() => validators.assertValidPassword('aaaaaaaaaaaaaaaaaaaaa'));
+
+  t.notThrows(() =>
+    validators.assertValidCredential({
+      email: '[email protected]',
+      password: 'password',
+    })
+  );
+  t.notThrows(() =>
+    validators.assertValidCredential({
+      email: '[email protected]',
+      password: 'password',
+      challenge: 'challenge',
+    })
+  );
+  t.notThrows(() =>
+    validators.assertValidCredential({
+      email: '[email protected]',
+      password: 'password',
+      verifyToken: 'verifyToken',
+    })
+  );
+  // challenge and verifyToken should not be both provided
+  t.throws(() =>
+    validators.assertValidCredential({
+      email: '[email protected]',
+      password: 'password',
+      challenge: 'challenge',
+      verifyToken: 'verifyToken',
+    })
+  );
+});

packages/backend/server/src/core/utils/validators.ts

@@ -21,6 +21,28 @@ function getAuthCredentialValidator() {
     .required();
 }
 
+function getAuthCredentialWithCaptchaValidator() {
+  return getAuthCredentialValidator()
+    .extend({
+      verifyToken: z.string().optional(),
+      challenge: z.string().optional(),
+    })
+    .refine(
+      data => {
+        const hasChallenge = !!data.challenge;
+        const hasVerifyToken = !!data.verifyToken;
+        return (
+          (!hasChallenge && !hasVerifyToken) ||
+          (hasChallenge && !hasVerifyToken) ||
+          (!hasChallenge && hasVerifyToken)
+        );
+      },
+      {
+        message: 'verifyToken and challenge should not be both provided',
+      }
+    );
+}
+
 function assertValid<T>(z: z.ZodType<T>, value: unknown) {
   const result = z.safeParse(value);
 
@@ -45,8 +67,10 @@ export function assertValidPassword(password: string) {
 export function assertValidCredential(credential: {
   email: string;
   password: string;
+  challenge?: string;
+  verifyToken?: string;
 }) {
-  assertValid(getAuthCredentialValidator(), credential);
+  assertValid(getAuthCredentialWithCaptchaValidator(), credential);
 }
 
 export const validators = {