Context & Project choices should be case-insensitive

[ginatrapani]

Right now if I have an @Phone and an @phone context in my todo.txt, they get listed individually in the context picker. The picker should collapse contexts into one where the only difference is case.

[marsepu]

a simple way to fix this is to only add the lowercase version of each context to the picker. Would this be an OK fix for you? It's a simple patch that I have already banged out if you want it.

[ginatrapani]

Yes, please send on the pull request so I can test out the fix. Thank you!
On Jul 6, 2012 9:09 PM, "Mario Sepulveda" <
[email protected]>
wrote:

a simple way to fix this is to only add the lowercase version of each
context to the picker. Would this be an OK fix for you? It's a simple patch
that I have already banged out if you want it.

---

Reply to this email directly or view it on GitHub:

#114 (comment)

[chuckbjones]

@marsepu, can you send a pull request for this one as well? Thanks

[marsepu]

Charles,

I sent a pull request for this over a week ago.

-Mario

Sent from my iPhone

On Jul 23, 2012, at 12:58 AM, Charles Jones [email protected] wrote:

@marsepu, can you send a pull request for this one as well? Thanks

---

Reply to this email directly or view it on GitHub:
#114 (comment)

[chuckbjones]

@ginatrapani This is another one that looks like it was never applied.

[ginatrapani]

When I went to apply this locally, there was a conflict:

<<<<<<< HEAD
        [projects addObject:[[inputText substringWithRange:[match rangeAtIndex:1]] stringByTrimmingCharactersInSet: [NSCharacterSet whitespaceCharacterSet]]];
=======
    NSString* theProjectInLowercase = [[inputText substringWithRange:[match rangeAtIndex:1]] lowercaseString];
        [projects addObject:theProjectInLowercase];
>>>>>>> d2c10de... Fixed issue #114  - Context & Project choices should be case-insensitive

I want to get the resolution right. I shouldn't delete stringByTrimmingCharactersInSet: [NSCharacterSet whitespaceCharacterSet]]] but I'm not confident about the right way to merge these changes.

[chuckbjones]

I'm not sure why it's trimming whitespace in the first place, but I just sent a new PR that maintains it.