run repolinter on repolinter using repolinter-action #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for now, we're just using the default ruleset, since it covers the most common things, and it already passes. We can certainly customize that down the road with other rules.
If and when we do use a custom ruleset file, we're probably want to put it in the
.githubdirectory. Even though it's common to have arepolinter.jsonfile in the root of the project, because this is for the repolinter project itself, I think that might cause some issues with some new tests that are being added in a separate PR. But none of that actually matters right now.(relates to todogroup/working-hours#8)