Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repolinter-action doesn't respect new config parsing logic #4

Closed
willnorris opened this issue Jul 9, 2021 · 2 comments
Closed

repolinter-action doesn't respect new config parsing logic #4

willnorris opened this issue Jul 9, 2021 · 2 comments
Assignees
@willnorris
Labels
released

Comments

@willnorris
Copy link
Member

repolinter-action has its own config parsing logic (https://github.com/todogroup/repolinter-action/blob/main/src/getConfig.ts) rather than deferring to repolinter. This is problematic because repolinter-action doesn't include the new 'extends' functionality added in todogroup/repolinter#207.

I can't think of any reason why repolinter-action should be trying to do configuration parsing at all, so I'll work to remove that and let repolinter take care of it. In initial testing, just skipping the getConfig call seems to break tests, so that will be my focus right now.
@willnorris willnorris self-assigned this Jul 9, 2021
@willnorris
Copy link
Member Author

oh, and it just occurred to me that the reason repolinter-action is doing this is because it is basically replicating all of the logic from https://github.com/todogroup/repolinter/blob/master/bin/repolinter.js, and prior to the above change, bin/repolinter.js was doing all of this work as well.

willnorris added a commit to willnorris/repolinter-action that referenced this issue Jul 18, 2021
@willnorris
remove custom config parsing logic
45d2aea 
use standard config parsing logic in repolinter, which includes
additional functionality like extending config files.

This is technically a breaking change, since config files are now
interpreted as relative to the repolinter working directory rather than
the root of the repository.  This difference can be seen in the 'runs in
a custom directory' test.  This only breaks if you are running
repolinter in a custom directory AND using a custom config file.

Fixes todogroup#4
willnorris added a commit to willnorris/repolinter-action that referenced this issue Jul 18, 2021
@willnorris
remove custom config parsing logic
e6eebaa 
use standard config parsing logic in repolinter, which includes
additional functionality like extending config files.

This is technically a breaking change, since config files are now
interpreted as relative to the repolinter working directory rather than
the root of the repository.  This difference can be seen in the 'runs in
a custom directory' test.  This only breaks if you are running
repolinter in a custom directory AND using a custom config file.

Fixes todogroup#4
willnorris added a commit to willnorris/repolinter-action that referenced this issue Jul 18, 2021
@willnorris
remove custom config parsing logic
d90de79 
use standard config parsing logic in repolinter, which includes
additional functionality like extending config files.

This is technically a breaking change, since config files are now
interpreted as relative to the repolinter working directory rather than
the root of the repository.  This difference can be seen in the 'runs in
a custom directory' test.  This only breaks if you are running
repolinter in a custom directory AND using a custom config file.

Fixes todogroup#4
willnorris added a commit to willnorris/repolinter-action that referenced this issue Jul 19, 2021
@willnorris
remove custom config parsing logic
696ce20 
use standard config parsing logic in repolinter, which includes
additional functionality like extending config files.

BREAKING CHANGE: Config file paths are now interpreted as relative to
the repolinter working directory rather than the root of the repository.
This difference can be seen in the 'runs in a custom directory' test.
This only breaks if you are running repolinter in a custom directory AND
using a custom config file.

Fixes todogroup#4
willnorris added a commit to willnorris/repolinter-action that referenced this issue Jul 22, 2021
@willnorris
fix: remove custom config parsing logic
ec42200 
use standard config parsing logic in repolinter, which includes
additional functionality like extending config files.

Config file paths are now interpreted as relative to the repolinter
working directory rather than the root of the repository.  This
difference can be seen in the 'runs in a custom directory' test.  This
only breaks if you are running repolinter in a custom directory AND
using a custom config file, which we don't think anyone is actually
doing.

Fixes todogroup#4
github-actions bot pushed a commit that referenced this issue Jul 22, 2021
@semantic-release-bot
chore(release): 1.7.2
727a038 
## [1.7.2](v1.7.1...v1.7.2) (2021-07-22)

### Bug Fixes

* remove custom config parsing logic ([#6](#6)) ([66551a2](66551a2)), closes [#4](#4)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.7.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willnorris willnorris

Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@willnorris