Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch i18n enable #16

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Patch i18n enable #16

wants to merge 14 commits into from

Conversation

node
Copy link
Member

@node node commented Aug 2, 2023 •
edited
Loading

  • add new language in config.toml : zh, Chinese
  • Create default three pages
  • Create zh.toml under i18n

Refer issue todogroup/ospodefinition.org#23

node added 7 commits August 1, 2023 22:03
@node
add i18n support
f244370 
Add Simplified Chinese this time.

Signed-off-by: Chris (Gentle) Yang <[email protected]>
@node
Create _index.md in Chinese
cbd227b 
Add the main page for Chinese.

Signed-off-by: Chris (Gentle) Yang <[email protected]>
@node
Create ospo-definition.md in Chinese
e0c8609 
Add first glossary: OSPO 

Signed-off-by: Chris (Gentle) Yang <[email protected]>
@node
Create _index.md
02246ac 
Signed-off-by: Chris (Gentle) Yang <[email protected]>
@node
Create _index.md
5054383 
Signed-off-by: Chris (Gentle) Yang <[email protected]>
@node
Create _index.md
e876468 
Signed-off-by: Chris (Gentle) Yang <[email protected]>
@node
Create zh_Hans.toml
a6b7b0c 
Signed-off-by: Chris (Gentle) Yang <[email protected]>
@netlify
Copy link

netlify bot commented Aug 2, 2023 •
edited
Loading

✅ Deploy Preview for ospoglossary ready!

Name Link
🔨 Latest commit c76c3ac
🔍 Latest deploy log https://app.netlify.com/sites/ospoglossary/deploys/65e67f0f74739d000837e820
😎 Deploy Preview https://deploy-preview-16--ospoglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@node
Copy link
Member Author

node commented Aug 2, 2023 •
edited
Loading

Looks like the zh_Hans.toml under i18n does not work correctly .

// UPDATE
Fix it.

@node node marked this pull request as ready for review August 2, 2023 04:06
node and others added 4 commits August 4, 2023 10:40
@node
Rename zh_Hans.toml to zh.toml
018bdf8 
Signed-off-by: Chris (Gentle) Yang <[email protected]>
@node
Update config.toml
1f12ee4 
Signed-off-by: Chris (Gentle) Yang <[email protected]>
@node
rename zh dir
4f4d610 
Signed-off-by: Chris (Gentle) Yang <[email protected]>
@cjyabraham @node
Remove CNCF GAnalytics
ed1d441 
Signed-off-by: Chris Abraham <[email protected]>
@node node force-pushed the patch-i18n-start branch from 0dee63c to ed1d441 Compare August 4, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@node @cjyabraham