fix(*): fix crash on node v18.0 caused by Import Attribute syntax #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbluhm
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Interesting...initially I was surprised this did not fail the test suite, but I guess the suite is using the latest versions of node v18 and v20. Great catch! We should probably add in a GitHub runner specifically for just v18.0.0 and v20.0.0 when you create the tests.
If you have a better suggestion over esmock, I am open to it...or a better way to handle the test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest refactoring (#392) caused this library to crash for node versions
v18.0-v18.19and20.0-20.9.These versions of node don't support "Import Attributes" (
import ... from ... with ...), they only support "Import Assertions" (import ... from ... assert ...).In a follow-up PR I'll update the test suite to run the oldest version of node that we support (v18.0.0). This is non-straightforward because esmock doesn't work well on this version of node