-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove icon mentions in variables.less etc. #88
Comments
This PR solves the issue. |
todc
added a commit
that referenced
this issue
May 9, 2013
Fixes #88 Remove icon mentions / variables.
Reopening since I reverted the merge. |
Glyphicons has been removed from BS3. It now exists in a separate project, https://github.com/twbs/bootstrap-glyphicons. |
Glyphicons are back as of twbs/bootstrap#9767 and the sprites are still gone. |
Closing since the sprites are no longer used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As this extends and overrides some parts of Bootstrap, it is not necessary to specify the glyphicons location in the variables.less or have sprite.less.
For those of us using composer, this can be difficult to work with, as our vendors folder looks like this:
vendors/
---- twitter/
---- ---- bootstrap/
---- todc/
---- ---- todc-bootstrap/
This is very problematic during the compilation phase of the .less files because the less compiler looks for the glyph icons images and fails to find them, as a result todo-bootstrap does not load.
So i have to do 1 of 2 things to resolve this:
Either steps are not ideal for a quality deploy situation, particularly when others may be using a project that also uses todc-bootstrap with a composer setup.
My recommendation would be that if your not modifying some aspect of bootstrap it may be best not include it here in todc-bootstrap. So can we please remove sprites.less file as i don't believe it changes anything from the defaults in bootstrap, and of course the sprite path variables. (mention of sprites.less would also need be removed from bootstrap.less).
This could be particular advantage to those of us using assetic as we will only have 1 set of sprites instead of 2 sets (4 files [as its 2 of each]) being loaded.
Let me know if you need any help with this, and i can work on a PR.
Thanks.
The text was updated successfully, but these errors were encountered: