Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove icon mentions in variables.less etc. #88

Closed
reecefowell opened this issue May 9, 2013 · 5 comments
Closed

Remove icon mentions in variables.less etc. #88

reecefowell opened this issue May 9, 2013 · 5 comments

Comments

@reecefowell
Copy link
Contributor

As this extends and overrides some parts of Bootstrap, it is not necessary to specify the glyphicons location in the variables.less or have sprite.less.

For those of us using composer, this can be difficult to work with, as our vendors folder looks like this:

vendors/
---- twitter/
---- ---- bootstrap/
---- todc/
---- ---- todc-bootstrap/

This is very problematic during the compilation phase of the .less files because the less compiler looks for the glyph icons images and fails to find them, as a result todo-bootstrap does not load.

So i have to do 1 of 2 things to resolve this:

  1. Delete the variables iconSpritePath, and iconWhiteSpritePath, but then thats not much better given its use in sprites.less.
  2. Copy the sprites from bootstrap to todc/todc-bootstrap/img directory.

Either steps are not ideal for a quality deploy situation, particularly when others may be using a project that also uses todc-bootstrap with a composer setup.

My recommendation would be that if your not modifying some aspect of bootstrap it may be best not include it here in todc-bootstrap. So can we please remove sprites.less file as i don't believe it changes anything from the defaults in bootstrap, and of course the sprite path variables. (mention of sprites.less would also need be removed from bootstrap.less).

This could be particular advantage to those of us using assetic as we will only have 1 set of sprites instead of 2 sets (4 files [as its 2 of each]) being loaded.

Let me know if you need any help with this, and i can work on a PR.

Thanks.

@reecefowell
Copy link
Contributor Author

This PR solves the issue.

@todc todc closed this as completed in 37aa4e8 May 9, 2013
todc added a commit that referenced this issue May 9, 2013
Fixes #88 Remove icon mentions / variables.
@todc
Copy link
Owner

todc commented May 10, 2013

Reopening since I reverted the merge.

@todc todc reopened this May 10, 2013
@acmetech
Copy link
Collaborator

Glyphicons has been removed from BS3. It now exists in a separate project, https://github.com/twbs/bootstrap-glyphicons.

@acmetech
Copy link
Collaborator

Glyphicons are back as of twbs/bootstrap#9767 and the sprites are still gone.

@acmetech
Copy link
Collaborator

Closing since the sprites are no longer used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants