Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rust Nightly to 2021-03-19 #2492

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Update Rust Nightly to 2021-03-19 #2492

merged 2 commits into from
Mar 23, 2021

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Mar 19, 2021

Pull Request Overview

This PR updates the nightly. Waiting for 2.0a to be merged.

Testing Strategy

This pull request was tested by...

TODO or Help Wanted

Warnings are addressed in a separate PR.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@bradjc bradjc added the blocked Waiting on something, like a different PR or a dependency. label Mar 19, 2021
alistair23
alistair23 previously approved these changes Mar 19, 2021
View reviewed changes
@hudson-ayers hudson-ayers force-pushed the tock-2.0-dev branch 3 times, most recently from 4f2099a to 15ae571 Compare March 22, 2021 16:26
@bors bors bot closed this Mar 22, 2021
@bors bors bot deleted the branch master March 22, 2021 19:54
@hudson-ayers hudson-ayers reopened this Mar 22, 2021
@github-actions github-actions bot added HIL This affects a Tock HIL interface. kernel risc-v RISC-V architecture WG-OpenTitan In the purview of the OpenTitan working group. labels Mar 22, 2021
@hudson-ayers hudson-ayers changed the base branch from tock-2.0-dev to master March 22, 2021 19:59
@hudson-ayers hudson-ayers dismissed alistair23’s stale review March 22, 2021 19:59

The base branch was changed.

@github-actions github-actions bot removed HIL This affects a Tock HIL interface. kernel risc-v RISC-V architecture WG-OpenTitan In the purview of the OpenTitan working group. labels Mar 22, 2021
@hudson-ayers hudson-ayers removed the blocked Waiting on something, like a different PR or a dependency. label Mar 22, 2021
hudson-ayers
hudson-ayers previously approved these changes Mar 22, 2021
View reviewed changes
@github-actions github-actions bot added the WG-OpenTitan In the purview of the OpenTitan working group. label Mar 22, 2021
@hudson-ayers
Copy link
Contributor

hudson-ayers commented Mar 22, 2021 •
edited
Loading

This surfaced a few warnings that I believe are false positives, where calling hil::Gpio::Pin::make_output() on a concrete struct produces errors, but calling hil::Gpio::Configure::make_output() on the same struct does not. I fixed these to not produce a warning, and filed an issue with Rust here: rust-lang/rust#83395

@bradjc
Copy link
Contributor Author

bradjc commented Mar 23, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 23, 2021

Build succeeded:

@bors bors bot merged commit a9f6750 into master Mar 23, 2021
@bors bors bot deleted the rust-2021-03 branch March 23, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alistair23 alistair23 alistair23 approved these changes

@lschuermann lschuermann lschuermann approved these changes

@hudson-ayers hudson-ayers hudson-ayers left review comments

Assignees
No one assigned
Labels
WG-OpenTitan In the purview of the OpenTitan working group.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bradjc @hudson-ayers @alistair23 @lschuermann