Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more information to use this library #92

Closed
wants to merge 1 commit into from

Conversation

ibiBgOR
Copy link

@ibiBgOR ibiBgOR commented Oct 5, 2019

To use this library one had to think around.
The new section on the README.md now describes
the setup process to use this library.

To improve the creation speed even more I
created the templates folder. All files
within this folder should be copied into a
new project.

To use this library one had to think around.
The new section on the README.md now describes
the setup process to use this library.

To improve the creation speed even more I
created the templates folder. All files
within this folder should be copied into a
new project.
@ibiBgOR
Copy link
Author

ibiBgOR commented Oct 5, 2019

I noticed that after renaming the crate name (#23) you missed to update the README. Also I added a section to describe how to setup the library within a new project (because not everybody wants to add example files into the repository itself ;) )

1. `deploy.sh` to deploy your code onto your hardware (please check if the correct
target is selected and the application name matches!)
1. `setup.sh` to download and setup the nightly build of Rust, Tockloader and the targets
1. `Cargo.toml` for your project (please remember to insert your name as autor and
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autor -> author

Comment on lines +12 to +14
[profile.dev]
panic = "abort"
lto = true # Link Time Optimization usually reduces size of binaries and static libraries
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the dev profile be used in practice? It may not even be worth configuring.

panic = "abort"
lto = true # Link Time Optimization usually reduces size of binaries and static libraries

[profile.release]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

profile.release could also have:

codegen-units = 1  # Enables some additional optimizations
opt-level = "z"  # Minimize size (probably more important than performance)

[package]
name = "<application>"
version = "0.1.0"
authors = ["That's you <[email protected]>"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to default to edition 2018?

@@ -0,0 +1,17 @@
/* Layout for the Hail board, used by the examples in this repository. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the layout files be symlinks to the top-level directory files (or the other way around), to make sure they are kept in sync? Same for rust-toolchain.

@Woyten
Copy link
Contributor

Woyten commented Nov 13, 2019

Two questions:

  • What is the status of this PR? There have been proposals by @jrvanwhy but no reaction to them.
  • What is the benefit of using the templates? In contrast to the example files, the template files are untested and risk running out of sync quickly. In my opinion, it is harder to make a broken template running than figuring what files you need by looking at the examples. A trade-off could be to place all example glue files to a dedicated location where they act as a template at the same time. Or you provide a mechanism to generate the example files out of the templates.

@jrvanwhy
Copy link
Collaborator

jrvanwhy commented Jan 2, 2020

Does anyone want to pick this up? I think it needs to be updated, and there have been no responses to review comments.

If no-one is interested in working on this then lets close it.

@torfmaster torfmaster closed this Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants