Remove the IPC drivers and test infrastructure. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Because libtock-rs uses static linking, it is difficult to run two Rust apps on one board. Few or none of the existing Tock platforms support statically linking multiple apps, making the IPC code untestable. To avoid having code and examples that cannot practically be used -- and to allow tests to pass -- we can remove all IPC code and its use cases.
|
Great, thanks a lot. I'll add tests for Trait objects, global muts and GPIO in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because libtock-rs uses static linking, it is difficult to run two Rust apps on one board. Few or none of the existing Tock platforms support statically linking multiple apps, making the IPC code untestable. To avoid having code and examples that cannot practically be used -- and to allow tests to pass -- we can remove all IPC code and its use cases.