-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ADC Channel parameter to the ADC API #555
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Alexandru Radovici <[email protected]>
Co-authored-by: Alexandru Radovici <[email protected]>
Do we need this for an older version of the kernel? Or is OK if this only works on latest master of the kernel? If the latter, it would be better to add a new get_counts command to the adc capsule and then use that command number. We made a mistake using command 0 for the count here, and if we fix it now that reduces the overhead for whenever tock 3.0 happens. |
This should work with the current version of the kernel. The kernel driver does not have a special command for returning the number of channels, command 0 still does this. |
@nikkoxp please modify the tests. |
Pull Request Overview
This pull request adds:
adc.rs
file to test all available channels at onceTesting Strategy
This pull request was tested on a microbit.
TODO or Help Wanted
Feedback