Support the latest newlib, libc++ and GCC (replaces #442)

[ppannuto]

#442 has an unfortunate chicken-and-egg problem wherein a commit new enough to checkout by hash in the dockerfile will only exist in the main libtock-c repo if the pull request comes from a branch within the libtock-c repo.

Hence this PR, which is based on the external branch, but is now coming from an internal branch. This isn't the most ergonomic or friendly solution, but this is also a rare enough issue [hopefully] that a little occasional human labor seems the path of least resistance.

I added commits to update the repo path, remove the unneeded patch file, and update the hash to check out.

---

TODO: Technically, the Makefile change to only patch if there's a patchfile is untested as newlib is still building on my laptop, but I doubt there will be any issue Hubris will get you every time... ceda51b

[alevy]

@ppannuto (and @bradjc & @lschuermann) does this require updating our binary repositories of pre-compiled libraries?

[lschuermann]

@alevy Yes, I guess so. @bradjc I have never built these toolchains, do you have this infrastructure already set up? We can then add these new artifacts to the mirrorcheck DB which will ensure that we have this replicated everywhere.

[ppannuto]

@lschuermann re build infra: that's what the dockerization is for; it should just be a matter of running each of the new docker-create.sh's.

That said, I'm building the toolchains currently and can send you built artifacts for the mirror when they finish.

[ppannuto]

@bradjc @lschuermann Here are updated built artifacts for mirrors:

https://www.dropbox.com/scl/fi/26qy6b90048splzzyd42z/libtock-newlib-4.4.0.20231231.zip?rlkey=3wyfyokyoj3i5ukcb9vrotvf5&dl=0
686af44e1bba625eb24b3cfb1fd2d48a61848c1edebbd49b5dbec554ebf2ea94 libtock-newlib-4.4.0.20231231.zip

https://www.dropbox.com/scl/fi/ns3ylwnoywgecgjz3vdjy/libtock-libc-14.1.0.zip?rlkey=x79iryk0yq2eme6f381sw4d2p&dl=0
46d50ea6a380f2c977e6aad187da216c35b793b31b3ea6de9646339c2a22f13c libtock-libc++-14.1.0.zip

I think this PR should be good to go

[bradjc]

Assuming it is supposed to be libtock-libc++-14.1.0.zip I have added these to the uva mirror.

[bradjc]

Why these changes?

[lschuermann]

Here are updated built artifacts for mirrors:

@ppannuto Sorry for the delay, added them to my mirror and the mirrorcheck URLs: tock/mirrorcheck@8cdd72e

[bradjc]

I guess we can vote, but I feel that these are not commands to build our project but are frozen steps to reproduce a dependency. The changes are also not related to the PR title.

[lschuermann]

I'm indifferent w.r.t. the @ changes. I agree they maybe shouldn't be part of this PR, but they are in a separate commit, and I don't have strong feelings about the actual changes either way.

Rest looks good.

[alevy]

I'm similarly agnostic regarding the @, though am sympathetic to @bradjc's kvetching over mixing this into a basically unrelated PR. I won't block either way, but I suggest @ppannuto just remove that commit (and maybe make it VERBOSE=1 option in a different PR?) in the name of peaceable coexistance and harmony

[ppannuto]

Updated. Now with 100% fewer controversial @ changes.

[ppannuto]

@alevy Why did this need a rebase? It should have merged cleanly, no?

The last commit ( 54b93c4 ) needs to update to point to 2e6baf2 now...

[alevy]

@alevy Why did this need a rebase? It should have merged cleanly, no?

Idk, but it wouldn't have merged cleanly, GitHub wouldn't let me hit the merge button.

[alevy]

@bradjc I think your comments have been addressed. Re-review (or just dismiss your old review)?

[ppannuto]

I do think the new github UX is confusing, but I think the "out of date" is just a warning that clicking Merge will create a merge commit [while rebase would allow just fast forward]. I don't think you _have_ to rebase—at least I didn't have to last week when I merged one that looked similar.

[alevy]

Ahhh.... ok

[ppannuto]

Undid the rebase with force push from my laptop still at old head. Should be good to go.

[alevy]

@bradjc ?

[lschuermann]

Let's give this one more day for last-call.

Addressed concerns.

[alistair23]

This seems to break builds

Fetching newlib from https://www.cs.virginia.edu/~bjc8c/archive/tock...
  Fetching https://www.cs.virginia.edu/~bjc8c/archive/tock/libtock-newlib-4.4.0.20231231.zip...
--2024-11-12 12:58:09--  https://www.cs.virginia.edu/~bjc8c/archive/tock/libtock-newlib-4.4.0.20231231.zip
Loaded CA certificate '/etc/ssl/certs/ca-certificates.crt'
Resolving www.cs.virginia.edu (www.cs.virginia.edu)... 128.143.67.8
Connecting to www.cs.virginia.edu (www.cs.virginia.edu)|128.143.67.8|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 355123001 (339M) [application/zip]
Saving to: 'libtock-newlib-4.4.0.20231231.zip'

libtock-newlib-4.4.0.20231231.zip      100%[============================================================================>] 338.67M  11.6MB/s    in 35s     

2024-11-12 12:58:45 (9.68 MB/s) - 'libtock-newlib-4.4.0.20231231.zip' saved [355123001/355123001]

sha256sum: 'standard input': no properly formatted checksum lines found
  WARNING: Fetching newlib from mirror https://www.cs.virginia.edu/~bjc8c/archive/tock failed!

[ppannuto]

#476