Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: update CI and build, remove poetry, test on py 310, 311, 312 #19

Merged
merged 2 commits into from
Jan 14, 2024

Conversation

fangchenli
Copy link
Contributor

No description provided.

@fangchenli fangchenli marked this pull request as ready for review January 13, 2024 21:41
@tobywf
Copy link
Owner

tobywf commented Jan 13, 2024

Awesome, thank you! I'll look at this closer next week. For the error, I think -mmacosx-version-min=10.13 could fix it? In build.py:

    extra_compile_args=[
        "-mmacosx-version-min=10.13",
        "-Wall",
        "-Wextra",
        "-Wpedantic",
        "-Werror",
    ],

One question I did have: The release workflow doesn't seem to automatically create a GitHub release? That isn't a blocker per se for this PR, but would be nice to keep if you feel up for it. Although testing the release workflow is a bit annoying; you can see one attempt in the old code via the branch workflow_release.

Copy link
Owner

@tobywf tobywf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thank you! Glad the compile argument for the macOS version worked.

@tobywf tobywf merged commit af4517d into tobywf:master Jan 14, 2024
5 checks passed
@tobywf
Copy link
Owner

tobywf commented Jan 14, 2024

For future reference, I had to use the env var MACOSX_DEPLOYMENT_TARGET instead of -mmacosx-version-min, so the wheel had the correct OS version in the name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants