Feature: Introduction, tutorial text #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See HelpViewController#98
tobyspark
added a commit
that referenced
this pull request
Mar 31, 2021
Feature: Introduction, tutorial text - Info scene has introduction and tutorial text, parsed from markdown files bundled with app. - Things screen has help scene modelled on Info scene. Has tutorial text, parsed from the markdown file. The content is presented at the header appropriate to the current video kind. This is pulled from metadata at the top of the markdown file. The accessible UX can fail here, see note. - Headers can be linked to within the document, by using a slugified form of the header. e.g. all lowercase, spaces to dashes, non-alphanumeric removed. Note: it seems that focussing on an accessibility element within the WKWebView is currently impossible in iOS 13. The javascript `focus()` was previously blessed, but recent security measures require the calling focus to have user intent to have an effect, e.g. works in a click handler, but not from the host app. This may well require the UX here to be revisited. Thoughts - Duplicate video kind relevant sections at the top of the help page - Automatically generate a table of contents at the top of the tutorial script - Try the deprecated `UIWebView` instead, there is lots of documentation of desired functionality working there
tobyspark
added a commit
that referenced
this pull request
Mar 31, 2021
Feature: Introduction, tutorial text - Info scene has introduction and tutorial text, parsed from markdown files bundled with app. - Things screen has help scene modelled on Info scene. Has tutorial text, parsed from the markdown file. The content is presented at the header appropriate to the current video kind. This is pulled from metadata at the top of the markdown file. The accessible UX can fail here, see note. - Headers can be linked to within the document, by using a slugified form of the header. e.g. all lowercase, spaces to dashes, non-alphanumeric removed. Note: it seems that focussing on an accessibility element within the WKWebView is currently impossible in iOS 13. The javascript `focus()` was previously blessed, but recent security measures require the calling focus to have user intent to have an effect, e.g. works in a click handler, but not from the host app. This may well require the UX here to be revisited. Thoughts - Duplicate video kind relevant sections at the top of the help page - Automatically generate a table of contents at the top of the tutorial script - Try the deprecated `UIWebView` instead, there is lots of documentation of desired functionality working there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: it seems that focussing on an accessibility element within the WKWebView is currently impossible in iOS 13. The javascript
focus()was previously blessed, but recent security measures require the calling focus to have user intent to have an effect, e.g. works in a click handler, but not from the host app.This may well require the UX here to be revisited. Thoughts
UIWebViewinstead, there is lots of documentation of desired functionality working there