Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(mysql): add support more kind for MEMBER OF content #1880

Merged
merged 4 commits into from
Jul 3, 2023
Merged

Fix(mysql): add support more kind for MEMBER OF content #1880

merged 4 commits into from
Jul 3, 2023

Conversation

brosoul
Copy link
Contributor

@brosoul brosoul commented Jul 3, 2023

The content type of 'Member of' is not just a string

image

georgesittas
georgesittas approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@georgesittas georgesittas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add another test for the MEMBER OF(custinfo->'$.zipcode') form; it should be transpiled to JSON_EXTRACT.

@tobymao tobymao merged commit a957388 into tobymao:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgesittas georgesittas georgesittas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brosoul @georgesittas @tobymao