Refactor!: move normalization logic in Dialect, update case-sensitivity info #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgesittas
commented
Jun 15, 2023
georgesittas
commented
Jun 15, 2023
tobymao
reviewed
Jun 15, 2023
tobymao
reviewed
Jun 15, 2023
tobymao
reviewed
Jun 15, 2023
georgesittas
changed the title
georgesittas
force-pushed
the
jo/refactor_normalizations
branch
from
b93574a to
b2c906b
Compare
tobymao
approved these changes
Jun 15, 2023
georgesittas
force-pushed
the
jo/refactor_normalizations
branch
from
b2c906b to
d5a1305
Compare
georgesittas
commented
Jun 16, 2023
adrianisk
pushed a commit
to adrianisk/sqlglot
that referenced
this pull request
Jun 21, 2023
…ty info (tobymao#1784) * Refactor!: move normalization logic in Dialect, handle BigQuery case-insensitivity * Move case_sensitive and _quote in Dialect to reduce overhead * Move can_identify to Dialect, pass it down to Generator as a dialect_property * Update other dialects that have case-insensitive identifiers too * Implement heuristic for treating tables as case-sensitive * Fix the heuristic condition * Improve condition * Add snowflake identifier docs in a comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.