Fix(snowflake): Handle form of CONVERT_TIMEZONE with a source TZ #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snowflake's [CONVERT_TIMEZONE](https://docs.snowflake.com/en/sql-reference/functions/convert_timezone) allows optionally specifying a source timezone for columns without timezone information. This currently causes incorrect SQL to be generated when parsed and re-rendered.
tobymao
reviewed
May 11, 2023
tobymao
reviewed
May 11, 2023
sqlglot/dialects/snowflake.py
Outdated
| def _parse_convert_timezone(args: t.Sequence) -> exp.Expression: | ||
| if len(args) == 3: | ||
| converted: t.List[exp.Expression] = [maybe_parse(arg, dialect=Snowflake) for arg in args] | ||
| return exp.Anonymous(this="CONVERT_TIMEZONE", expressions=converted) |
There was a problem hiding this comment.
exp.func("CONVERT_TIMEZONE", expression=...)
There was a problem hiding this comment.
I initially tried exp.func, but since CONVERT_TIMEZONE is in the parser.FUNCTIONS dict, it ends up calling this function again recursively on line 5414 of expressions.py and causing a recursion loop. (that's also why I was calling maybe_parse - I was looking at the body of exp.func, but it makes sense that it's not necessary here now)
tobymao
reviewed
May 11, 2023
georgesittas
approved these changes
May 11, 2023
tobymao
approved these changes
May 11, 2023
adrianisk
pushed a commit
to adrianisk/sqlglot
that referenced
this pull request
Jun 21, 2023
…ymao#1598) * Fix(snowflake): Handle form of CONVERT_TIMEZONE with a source TZ Snowflake's [CONVERT_TIMEZONE](https://docs.snowflake.com/en/sql-reference/functions/convert_timezone) allows optionally specifying a source timezone for columns without timezone information. This currently causes incorrect SQL to be generated when parsed and re-rendered. * Address code review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snowflake's CONVERT_TIMEZONE has two forms:
The second is required if the timestamp doesn't have timezone information. Currently, parsing
produces
when re-rendered, which is invalid. This PR still treats the target-only case as
exp.AtTimeZone, but parses the source-and-target case asexp.Anonymousso that rendering back to Snowflake will be correct.