Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(oracle): support KEEP (.. [FIRST|LAST] ..) window function syntax #1522

Merged
merged 3 commits into from
May 2, 2023
Merged

Feat(oracle): support KEEP (.. [FIRST|LAST] ..) window function syntax #1522

merged 3 commits into from
May 2, 2023

Conversation

georgesittas
Copy link
Collaborator

Fixes #1520

tobymao
tobymao reviewed May 2, 2023
View reviewed changes
tests/fixtures/identity.sql Outdated Show resolved Hide resolved
tobymao
tobymao reviewed May 2, 2023
View reviewed changes
sqlglot/dialects/oracle.py Outdated Show resolved Hide resolved
@tobymao tobymao merged commit 455b9e9 into main May 2, 2023
@tobymao tobymao deleted the jo/oracle_window_fixes branch May 2, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobymao tobymao tobymao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KEEP in an Oracle SQL Statement is retrieving a ParseError
2 participants
@georgesittas @tobymao