Fix: redshift len->length closes #1741

tobymao · Jun 7, 2023 · 6168fbf · 6168fbf
1 parent 0cc09cf
commit 6168fbf
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/sqlglot/expressions.py b/sqlglot/expressions.py
@@ -4167,7 +4167,7 @@ class Right(Func):
 
 
 class Length(Func):
-    pass
+    _sql_names = ["LENGTH", "LEN"]
 
 
 class Levenshtein(Func):

diff --git a/tests/dialects/test_redshift.py b/tests/dialects/test_redshift.py
@@ -32,14 +32,20 @@ def test_redshift(self):
                 "presto": "NOT x",
             },
         )
-
         self.validate_all(
             "x is not false",
             write={
                 "redshift": "NOT x IS FALSE",
                 "presto": "NOT NOT x",
             },
         )
+        self.validate_all(
+            "LEN(x)",
+            write={
+                "redshift": "LENGTH(x)",
+                "presto": "LENGTH(x)",
+            },
+        )
 
         self.validate_all(
             "SELECT SYSDATE",
-Original file line number
+Diff line change
@@ Expand Up / @@ -4167,7 +4167,7 @@ class Right(Func): @@
     class Length(Func):
-        pass
+        _sql_names = ["LENGTH", "LEN"]
     class Levenshtein(Func):
@@ Expand Down @@