[18Uruguay] Interest should not be paid for penalty loans

[patrikolesen]

Fixes #11447

Can potentially break existing games

Before clicking "Create"

• Branch is derived from the latest master
• Add the pins or archive_alpha_games label if this change will break existing games
• Code passes linter with docker compose exec rack rubocop -a
• Tests pass cleanly with docker compose exec rack rake

Implementation Notes

Explanation of Change

Screenshots

Any Assumptions / Hacks

[bentziaxl]

did you test this code? in the original implementation (interest_on_loans.rb),
owed = interest_owed(entity) is inside the loop, to update the owed value.
What's updating the owed value to prevent an infinite loop?

[bentziaxl]

If you do need to add that line, it looks like this code is identical to the one in interest_on_loans.rb, except
entity.loans.size < maximum_loans(entity)

could you make the max high enough and then prevent this duplication?

[patrikolesen]

There are two changes here from the "original"

1. That you in this case are allowed to take more than what is normally allowed
2. It is by intension that owed is not updated. We do not want to pay interest on loans that we are forced to take due to interest payments. The entity.cash is increased for every loop so it will drop out when the entity has enough cash to pay the interest