Merge fork #34
Merged
Merge fork #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By explicitly implementing `deserialize_str` which calls `visit_str` instead of `visit_bytes`.
By explicitly implementing `deserialize_identifier` to delegate to `deserialize_str`.
Fix deserialization of nested tuple
Minor change to support rust version >= 1.40.0
Add test for ser/de of struct with vec of tuples (issue #17)
Minor changes and package configuration changed.
625081a new torrust-serde-bencode package (Jose Celano) Pull request description: Minor changes and package configuration changed. ACKs for top commit: josecelano: ACK 625081a Tree-SHA512: 59d6937975f2cf646d90da3880404100c16ff81a8c662b4bc8ad52dae2a81e77172e6d3f95ac70f3b0c17c2be3d1093479c82d62b06807d16b3646c21639f515
43ba81e Introduce failing test for flattened enums (Nicholas Rempel) Pull request description: From: toby#31 (comment) By: [nrempel](https://github.com/nrempel) ``` Hello, This pull request adds a failing test for deserializing flattened structs containing enums. Is it expected that this test should pass or is there some serde caveat that I'm unaware of here? I'm happy to take a crack at fixing this if it's fixable. Any pointers would be appreciated. Thanks. ``` ACKs for top commit: josecelano: ACK 43ba81e Tree-SHA512: aa996152a2a7a583b7a6eff54b99edfb0872ebf77803cab376e9db19200cbacd42bef11fc51a33254fd13d6eb5f67f483e23a90bf008f2fe1ade4aa55118453e
a1597cc Add cargo-fuzz fuzzer (5225225) Pull request description: From: toby#29 By: [5225225](https://github.com/5225225) `This adds a https://github.com/rust-fuzz/cargo-fuzz fuzzer which I used to find toby#28` ACKs for top commit: josecelano: ACK a1597cc Tree-SHA512: 45c604038a0e48b3057612ff4a28ffce1f4985f94c8fc3807d08daff8e94f7f40173bb690296619f928075101d2712abd984ec27849d12621a72606113baa501
decdff6 Avoid eagerly allocating too much memory (5225225) Pull request description: From: toby#30 By: @5225225 Fixes: toby#28 ACKs for top commit: josecelano: ACK decdff6 Tree-SHA512: 5152d509678d198965b87ad8f07ca59d88805dc94ffc06d54b7fba0ae25f7b07fb3137a920c36ce4c89d6fb267491116a4141502bd10ed0525f7c3289195c721
6ce2e9d test: add a failing test for nested list deserialization (Jose Celano) Pull request description: Add failing test for this bug: torrust/torrust-index#266 ACKs for top commit: josecelano: ACK 6ce2e9d Tree-SHA512: bd40e3e7b5926b4ce4bddf468c31c776729d5e23705334e134ea5aff228b8cc8fd67616aee13f32fc733abba194eab696e1d4c0c199b1ec1e1619458013bfc6b
Some of them were allow: - #[allow(clippy::extra_unused_lifetimes)] - #[allow(clippy::cast_possible_wrap)] - #[allow(clippy::needless_pass_by_value)] Pending to review.
b3b2a44 fix: [#9] Clipply errors (Jose Celano) Pull request description: Some of them were allow: - #[allow(clippy::extra_unused_lifetimes)] - #[allow(clippy::cast_possible_wrap)] - #[allow(clippy::needless_pass_by_value)] Pending to review. Top commit has no ACKs. Tree-SHA512: 65cfae5a9bc119b04ebca25b847024bc17ec727f9290f11dd855bcf104990177cf46d596263babfdaba7e4f86967170cb759580fe0382ddb7bc5a9e799a87268
1ea262d ci: add benchmarking workflow (Jose Celano) Pull request description: Top commit has no ACKs. Tree-SHA512: 3e3711e4c7eab636f08a892573b45dc48a1c2338fd120355140571760588c4d00db6fda36b36be81a7c69a80d4158874331291a1406901d92b9ad8ba771cbb23
Don't know why it was ignored. It's passing.
252849f ci: add coverage workflow (Jose Celano) 5bc8202 ci: ignore failing tests (Jose Celano) Pull request description: ACKs for top commit: josecelano: ACK 252849f Tree-SHA512: 0055ea39e3ab729e271d42ae032eb2896c582acf62511d6b45791c051e951021a7c9656453589e5b9d89fbcf495f8b2b9edd09b0462771be6ebcf0343251448d
for deserialization with nested lists where child lists contain integers.
THe initial intention was to mantain a fork, but finally we will merge the fork changes into the upstream repo.
f58baf7 chore: undo package rename (Jose Celano) 9833274 tests: add unit test for Value with serde_test (Jose Celano) f94c198 chore: add dev dependency serde_test (Jose Celano) 1eab404 test: add unit tests to Value (Jose Celano) b85b2a4 chore: add code coverage dir to gitignore (Jose Celano) Pull request description: ACKs for top commit: josecelano: ACK f58baf7 Tree-SHA512: e578cba38165a029b2eebda14fa5abc4a6214851798f7960e695e43c5f980b1f45671ee2d7eb30d624722028144f862f9035d9a4461420eacbc972c3dd8c38a6
|
ACK e894328 |
Merged
josecelano
added a commit
that referenced
this pull request
Oct 9, 2023
97b0896 docs: update README (Jose Celano) Pull request description: Remove message: >Archived: I no longer maintain this repo as I've moved to [Go full-time](https://charm.sh/). Please see [torrust/torrust-serde-bencode](https://github.com/torrust/torrust-serde-bencode) for a maintained fork. In the end, I was added as a maintainer and [merged upgrades from the fork](#34). Top commit has no ACKs. Tree-SHA512: e578cba38165a029b2eebda14fa5abc4a6214851798f7960e695e43c5f980b1f45671ee2d7eb30d624722028144f862f9035d9a4461420eacbc972c3dd8c38a6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been working on a fork because this project was inactive, but I contacted @toby, who made me a maintainer and gave it access to publish new versions.
I was trying to fix a bug I found here. . After debugging, I realized the bug was already fixed in this repo but has yet to be included in a new release.
I've been working on the fork and I would like to merge those changes back and publish the version
v0.2.4on crates.io.The changes I've made so far are:
Valuestruct.