Even more cleanups #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obfuscation is useless in an open source game.
Includes prefixed document.hidden property with respective visibilitychanged event and redundant support for navigator.language / lack of navigator.languages check.
All modern browsers should support \1 as the compression prefix, even outside of Electron or recent Chromium versions. Local storage / IndexedDB platform wrappers were removed a while ago.
Remove secrets that are no longer used and fetchDiscounts preload step.
webkitImageSmoothingEnabled got deprecated back in 2016. globalConfig.smoothing.quality is now properly typed as well.
The Math polyfills might still be needed (even though they are polluting the Math object) and I'm not sure about DOM polyfills yet.
Also remove an unused function and switch to crypto.randomUUID() for savegame ID generation.
Provided epsilon parameter was used for Y axis but ignored for X axis. Some useless return statements are also removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explained in detail in the commit messages. In short, this mostly consists of removing dead code, support for legacy browsers and savegames. A bugfix for Vector#equalsEpsilon is also included. Dependency on
rushawas removed since SHA1 is no longer used anywhere.