Redo ESLint and TypeScript configuration #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many configuration files in this repository were created a long time ago, then were modified as problems occurred. Now that there is TypeScript support, it makes sense to clean up this mess, at least by making small steps. This configuration is based on strict settings, but most of these are currently disabled - otherwise it would be too hard to work with existing JavaScript code. The downside of this change is pollution of files with warnings and errors, even though they are valid. - ESLint/TypeScript upgraded - TS configuration is now shared between arbitrary Node scripts, Gulp files and the Electron wrapper - A few eslint-disable comments are removed
There was a problem hiding this comment.
retroactively approve a PR challenge
EDIT: nope doesn't work, anyway here's the comments I sent in the Discord for reference, and their resolutions
- you import
pathto call a single method on it, yet you import{ fileURLToPath }fromurl!!!- habit, due to generic names and possible additional usage in the future
- https://eslint.org/docs/latest/use/configure/configuration-files#specifying-files-and-ignores
minimatch supports regex stuff
or brace expansion- this was resolved in the latest commit
- btw why is tsconfig.json in src now?
- why isn't the eslint-disable comment at
removed?
- still relevant and is part of game code
- for the
lintscript, for some bizarre reason&acts like a semicolon soeslint . & tsc & tsc -p srcsuffices- turns out this works only on Windows, and the sensible option
;works only on Linux and macOS
- turns out this works only on Windows, and the sensible option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many configuration files in this repository were created a long time ago, then were modified as problems occurred. Now that there is TypeScript support, it makes sense to clean up this mess, at least by making small steps. This configuration is based on strict settings, but most of these are currently disabled - otherwise it would be too hard to work with existing JavaScript code. The downside of this change is pollution of files with warnings and errors, even though they are valid.
This was already reviewed by @EmeraldBlock, but expect some breakage (mostly those warnings)