Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make secure cookie flag optional #22

Merged
merged 1 commit into from
Apr 20, 2011
Merged

Make secure cookie flag optional #22

merged 1 commit into from
Apr 20, 2011

Conversation

mig-hub
Copy link

@mig-hub mig-hub commented Apr 19, 2011

Hello,

After the discussion we had on the issue page with thibaudgg, here is my fork for having secure cookie flag optional.

It includes tests, a warning and documentation.

Let me know what you think.

Thank you very much,
Mig

@tobmatth
Copy link
Owner

Hey there,

thanks for your contribution, looks good so far. I'll pull in your changes tomorrow unless @rymai or @thibaudgg are faster :)

Regards,
Tobi

@rymai rymai merged commit a1cc297 into tobmatth:master Apr 20, 2011
@rymai
Copy link
Collaborator

rymai commented Apr 20, 2011

Hey,

I've merged this, and also made some cleaning in the code, there is still need to clean up stuff I think but it's a first step...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants