This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
Reregister existing framework and support escape of slash in task names #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that when I tried to reregister an existing framework I received a mismatch of the framework ID in different fields:
Failed to validate scheduler::Call: 'framework_id' differs from 'subscribe.framework_info.id'
Since the subscribe call sets the framework ID to null.
This sets it to the framework ID given if defined, and prints out the error output from Mesos upon failure to register.
In addition, since we wanted to use task names with slashes to match the marathon groups we're using, I added an escape of the task name to underscores, like marathon does internally.