Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix permission issues with Dockerfile nonroot implementation #274

Merged
merged 5 commits into from
Mar 15, 2024
Merged

Fix permission issues with Dockerfile nonroot implementation #274

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bcfde8c
Dockerfile readability
tobiasehlert Mar 15, 2024
33d3b11
update nonroot things
tobiasehlert Mar 15, 2024
75e9165
adding chmod parameter to copy command
tobiasehlert Mar 15, 2024
27fdad8
changing instructions to be upper case
tobiasehlert Mar 15, 2024
e401c3b
fixing permissions of binary
tobiasehlert Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# get golang container
FROM golang:1.22.1
FROM golang:1.22.1 AS builder

# get args
ARG apiVersion=unknown
Expand All @@ -21,23 +21,24 @@ RUN CGO_ENABLED=0 go build -ldflags="-w -s -X 'main.apiVersion=${apiVersion}'" -


# get alpine container
FROM alpine:3.19.1
FROM alpine:3.19.1 AS app

# create nonroot user
RUN addgroup -S nonroot \
&& adduser -S nonroot -G nonroot
# create workdir
WORKDIR /opt/app

# add ca-certificates
# add ca-certificates and tzdata
RUN apk --no-cache add ca-certificates tzdata

# create workdir
WORKDIR /root/
# create nonroot user and group
RUN addgroup -S nonroot && \
adduser -S nonroot -G nonroot && \
chown -R nonroot:nonroot .

# copy binary from first container
COPY --from=0 /go/src/app .
# set user to nonroot
USER nonroot:nonroot

# set user
USER nonroot
# copy binary from builder
COPY --from=builder --chown=nonroot:nonroot --chmod=544 /go/src/app .

# expose port 8080
EXPOSE 8080
Expand Down