TeslaMate encryption of API tokens #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasehlert
added
enhancement
tobiasehlert
force-pushed
the
feature-encrypt-api-tokens
branch
from
8804cdc to
a4aa6fe
Compare
|
@tobiasehlert What is left before this can be merged? |
Co-authored-by: Leland Sindt <[email protected]>
@noocyte, the problem is that the decryption doesn't work and I was kind of stuck. |
Co-authored-by: Leland Sindt <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
richard1122
pushed a commit
to richard1122/teslamateapi
that referenced
this pull request
Jun 26, 2022
…)" This reverts commit 3f9e8c4.
richard1122
added a commit
to richard1122/teslamateapi
that referenced
this pull request
Jun 26, 2022
…)" This reverts commit 3f9e8c4.
richard1122
added a commit
to richard1122/teslamateapi
that referenced
this pull request
Jun 26, 2022
…)" This reverts commit 3f9e8c4.
richard1122
added a commit
to richard1122/teslamateapi
that referenced
this pull request
Jun 26, 2022
…)" This reverts commit 3f9e8c4.
|
@tobiasehlert Could you please mention in your new Release notes, that you have to add the encryption key to your service section as well? |
|
@pkuehnel I did mention that in the beginning and updated the readme with the ENCRYPTION_KEY parameter. |
|
@tobiasehlert Much better. Thanks :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for AES_256_GCM encrypted API tokens implemented by PR teslamate-org/teslamate#2360 in TeslaMate.