-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Matrix Testing & Typing Error #468
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #468 +/- ##
==========================================
+ Coverage 60.67% 60.75% +0.07%
==========================================
Files 23 23
Lines 3537 3544 +7
==========================================
+ Hits 2146 2153 +7
Misses 1391 1391
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for fixing this! Happy for this to be merged directly into main as soon as the remaining tests have passed, and released as 1.5.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @freemansw1 ! I am also happy for you to merge this as soon as you see this.
Just a quick question: would it make sense to import annotations
in all test files and submodules, even those that currently do not contain characters that are affected?
Resolves #467 . Note that the initial commit should fail CI as I haven't implemented the typing fix yet (intentionally).