Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Matrix Testing & Typing Error #468

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

freemansw1
Copy link
Member

Resolves #467 . Note that the initial commit should fail CI as I haven't implemented the typing fix yet (intentionally).

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.75%. Comparing base (706b3ee) to head (e527b5e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
+ Coverage   60.67%   60.75%   +0.07%     
==========================================
  Files          23       23              
  Lines        3537     3544       +7     
==========================================
+ Hits         2146     2153       +7     
  Misses       1391     1391              
Flag Coverage Δ
unittests 60.75% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@w-k-jones w-k-jones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for fixing this! Happy for this to be merged directly into main as soon as the remaining tests have passed, and released as 1.5.5

@w-k-jones w-k-jones added this to the Version 1.5.5 milestone Dec 13, 2024
Copy link
Member

@JuliaKukulies JuliaKukulies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @freemansw1 ! I am also happy for you to merge this as soon as you see this.

Just a quick question: would it make sense to import annotations in all test files and submodules, even those that currently do not contain characters that are affected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import tobac broken for Python<3.10
3 participants