Bugfix in grid spacing

[fsenf]

Description

I found a bug in the get_spacing functionality and fixed it.

Problem: If x is storing in ascending and y in descending order (and vice versa), than the grid spacing increment subtract eachother - which is not wanted.

Solution: used the absolute value

Extension:

• also added a new keyword average_type to allow to switch between averaging strategies
• implemented geometric mean which more appropriate in my view

Checklist

• Have you followed our guidelines in CONTRIBUTING.md?
• Have you self-reviewed your code and corrected any misspellings?
• Have you written documentation that is easy to understand?
• Have you written descriptive commit messages?
• Have you added NumPy docstrings for newly added functions?
• Have you formatted your code using black?
• If you have introduced a new functionality, have you added adequate unit tests?
• Have all tests passed in your local clone?
• If you have introduced a new functionality, have you added an example notebook?
• Have you kept your pull request small and limited so that it is easy to review?
• Have the newest changes from this branch been merged?

Cheers, Fabian.

PS: should be very easy to review and merge back

[github-actions]

Linting results by Pylint:

Your code has been rated at 8.72/10 (previous run: 8.72/10, +0.00)
_{The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the RC_v1.5.x branch.
A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.}

[codecov]

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 56.88%. Comparing base (2e4c9d0) to head (dac29e8).
Report is 9 commits behind head on RC_v1.5.x.

Files	Patch %	Lines
tobac/utils/general.py	62.50%	3 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##           RC_v1.5.x     #400      +/-   ##
=============================================
- Coverage      56.91%   56.88%   -0.04%     
=============================================
  Files             20       20              
  Lines           3440     3444       +4     
=============================================
+ Hits            1958     1959       +1     
- Misses          1482     1485       +3     

Flag	Coverage Δ
unittests	56.88% <62.50%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[w-k-jones]

Thanks for catching this @fsenf ! I fixed another bug where the y coordinate was being used for both x and y differences, and change the keyword average_type to average_method to be more in line with other keywords for specifying what approach to use

[fsenf]

@JuliaKukulies : I selected you as 2nd reviewer. Is this fine for you?

[JuliaKukulies]

@JuliaKukulies : I selected you as 2nd reviewer. Is this fine for you?

Looks good to me, @fsenf! I have a minor question/suggestion, but tested the code and am fine to merge this PR right away as well! Thanks for fixing this!