Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2d coordinate interpolation #250

Merged

Conversation

w-k-jones
Copy link
Member

Fixes the problem with 2d coordinate interpolation producing object dtypes in feature_detection raised in #240 that was the cause of the bug in #239

Ideally this could be released as part of v1.4.2, but the changes to the utils structure as part of v1.5 make it impractical to separate

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

@w-k-jones w-k-jones added the bug Code that is failing or producing the wrong result label Feb 17, 2023
@w-k-jones w-k-jones added this to the Version 1.5 milestone Feb 17, 2023
@w-k-jones w-k-jones self-assigned this Feb 17, 2023
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 47.15% // Head: 47.15% // No change to project coverage 👍

Coverage data is based on head (b78f1e0) compared to base (ce390a3).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           RC_v1.5.0     #250   +/-   ##
==========================================
  Coverage      47.15%   47.15%           
==========================================
  Files             14       14           
  Lines           2704     2704           
==========================================
  Hits            1275     1275           
  Misses          1429     1429           
Flag Coverage Δ
unittests 47.15% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tobac/utils/general.py 69.80% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@JuliaKukulies JuliaKukulies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Yes true, it will be a bit of a pain to merge this back to v1.5 with the utils module split. However, I think we should go for it nonetheless, since it makes sense to include this in v1.4.2 as you say

Copy link
Member

@freemansw1 freemansw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this, thanks for the bugfix! I agree that 1.4.2 would be better but I'm happy to wait until 1.5.0 if it's a pain. 1.5.0 in theory shouldn't be far behind.

@freemansw1
Copy link
Member

Once #251 is merged, I think this PR can be closed, right?

@w-k-jones
Copy link
Member Author

I don't think the changes got moved across to the v1.5 branch due to the change in the utils submodule structure, so I'll wait until #257 is merged and then see if this can be closed or merged

@freemansw1
Copy link
Member

Yeah, good point @w-k-jones! Let's get this merged (after #257).

@JuliaKukulies
Copy link
Member

#257 merged, good to go!

@w-k-jones w-k-jones merged commit 819bba5 into tobac-project:RC_v1.5.0 Feb 23, 2023
@w-k-jones w-k-jones deleted the fix_2d_latlon_interp_list branch February 23, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code that is failing or producing the wrong result
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants