-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 2d coordinate interpolation #250
Fix 2d coordinate interpolation #250
Conversation
Codecov ReportBase: 47.15% // Head: 47.15% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## RC_v1.5.0 #250 +/- ##
==========================================
Coverage 47.15% 47.15%
==========================================
Files 14 14
Lines 2704 2704
==========================================
Hits 1275 1275
Misses 1429 1429
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Yes true, it will be a bit of a pain to merge this back to v1.5 with the utils module split. However, I think we should go for it nonetheless, since it makes sense to include this in v1.4.2 as you say
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this, thanks for the bugfix! I agree that 1.4.2 would be better but I'm happy to wait until 1.5.0 if it's a pain. 1.5.0 in theory shouldn't be far behind.
Once #251 is merged, I think this PR can be closed, right? |
I don't think the changes got moved across to the v1.5 branch due to the change in the utils submodule structure, so I'll wait until #257 is merged and then see if this can be closed or merged |
Yeah, good point @w-k-jones! Let's get this merged (after #257). |
#257 merged, good to go! |
Fixes the problem with 2d coordinate interpolation producing
object
dtypes in feature_detection raised in #240 that was the cause of the bug in #239Ideally this could be released as part of v1.4.2, but the changes to the utils structure as part of v1.5 make it impractical to separate