Add tests for column names in feature detection and tracking #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportBase: 39.30% // Head: 39.25% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## hotfix #227 +/- ##
==========================================
- Coverage 39.30% 39.25% -0.06%
==========================================
Files 11 11
Lines 2249 2247 -2
==========================================
- Hits 884 882 -2
Misses 1365 1365
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
freemansw1
approved these changes
Jan 23, 2023
JuliaKukulies
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New tests have been added to check that the column names in feature detection mirror the names of the coords in the input data. Existing tests for tracking have been added to ensure that the column names of the tracking dataframe matches those of the features dataframe aside from the "cell" column, and that column names are not duplicated.
Tracking has also been modified to overwrite the features dataframe with a copy to prevent modifications to the input dataframe, and the temporary column names for the predictive tracking workaround have been further obfuscated to avoid any likely conflict with other column names.