-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DeprecationWarnings to several old functions #200
Add DeprecationWarnings to several old functions #200
Conversation
Codecov ReportBase: 35.06% // Head: 34.89% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## RC_v1.5.0 #200 +/- ##
=============================================
- Coverage 35.06% 34.89% -0.18%
=============================================
Files 10 10
Lines 2099 2115 +16
=============================================
+ Hits 736 738 +2
- Misses 1363 1377 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @freemansw1. After my experience with these functions I think that this step is the right way to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, that makes sense @freemansw1. Thanks for your changes! Is there any clever way we can go about the coverage in pull requests like this or are we just ignoring it because we know we only added warnings?
@JuliaKukulies we have changed the code coverage threshold to -1% in #183, but I don't know that those changes have been merged back into v1.5.0 yet. |
Thanks for the quick reviews! |
Right, sorry! I was aware of the change with #183 but misread and thought this would be even more than -1 %. There are probably a few things that haven't merged back yet, but I guess this will be done directly after the release so never mind |
Yeah, now that we're so close to 1.4.0, I'm planning to wait to merge 1.4.0 into 1.5.0 until release. |
This PR is simply to add several DeprecationWarnings to various functions that have been discussed before as needing to be removed or substantially reworked for v2.0. Getting these DeprecationWarnings into v1.5 should give users enough time to migrate away from the functions.
Resolves #198 and #158.