Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage via Github Actions #124

Merged
merged 19 commits into from
Jun 27, 2022
Merged

Add code coverage via Github Actions #124

merged 19 commits into from
Jun 27, 2022

Conversation

freemansw1
Copy link
Member

Resolves #94 and adds code coverage via codecov.io and GitHub Actions.

We will want to merge this as a squash merge.

@freemansw1 freemansw1 added the enhancement Addition of new features, or improved functionality of existing features label Apr 24, 2022
@freemansw1 freemansw1 added this to the Version 1.5 milestone Apr 24, 2022
@freemansw1 freemansw1 self-assigned this Apr 24, 2022
@freemansw1
Copy link
Member Author

Apologies for spamming your email with the failed attempts here; this ended up being nontrivial.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (dev@ae378d2). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev     #124   +/-   ##
======================================
  Coverage       ?   31.76%           
======================================
  Files          ?       11           
  Lines          ?     2043           
  Branches       ?        0           
======================================
  Hits           ?      649           
  Misses         ?     1394           
  Partials       ?        0           
Flag Coverage Δ
unittests 31.76% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae378d2...8824541. Read the comment docs.

@freemansw1
Copy link
Member Author

Note that we can turn those coverage comments off (I like them, and am happy for them to be on).

Copy link
Member

@JuliaKukulies JuliaKukulies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, well done @freemansw1! It looks all good to me. Yes, probably a good idea to squash the commits. I also like the comments and think it could be useful to leave them on. I assume that the issue with the missing base report will be automatically fixed when the PR is merged?

@freemansw1
Copy link
Member Author

Thanks @JuliaKukulies! Yes, it should be the comparison version, but since this has never been run before, there's nothing to compare to.

@freemansw1 freemansw1 linked an issue May 15, 2022 that may be closed by this pull request
@freemansw1
Copy link
Member Author

I am inclined to go ahead and merge this after #141 is resolved and 1.3.1 is out, unless you think we should try to get it in for 1.3.1 @JuliaKukulies?

@JuliaKukulies
Copy link
Member

I think that sounds like a good plan, especially when there will be an extra bug fix release 1.3.2, it can be released together with #140 as you suggested (and I think it would make sense and we do not need to wait for #140 to be reviewed to release 1.3.1).

@freemansw1 freemansw1 modified the milestones: Version 1.5, Version 1.3.2 Jun 22, 2022
@freemansw1 freemansw1 merged commit 6460b1d into dev Jun 27, 2022
@freemansw1 freemansw1 deleted the dev-codecov-test branch September 9, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Addition of new features, or improved functionality of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Code Coverage to main and dev
3 participants