-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code coverage via Github Actions #124
Conversation
Apologies for spamming your email with the failed attempts here; this ended up being nontrivial. |
Codecov Report
@@ Coverage Diff @@
## dev #124 +/- ##
======================================
Coverage ? 31.76%
======================================
Files ? 11
Lines ? 2043
Branches ? 0
======================================
Hits ? 649
Misses ? 1394
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Note that we can turn those coverage comments off (I like them, and am happy for them to be on). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, well done @freemansw1! It looks all good to me. Yes, probably a good idea to squash the commits. I also like the comments and think it could be useful to leave them on. I assume that the issue with the missing base report will be automatically fixed when the PR is merged?
Thanks @JuliaKukulies! Yes, it should be the comparison version, but since this has never been run before, there's nothing to compare to. |
I am inclined to go ahead and merge this after #141 is resolved and 1.3.1 is out, unless you think we should try to get it in for 1.3.1 @JuliaKukulies? |
Resolves #94 and adds code coverage via codecov.io and GitHub Actions.
We will want to merge this as a squash merge.