Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pull_request_template.md in .github/ #120

Merged
merged 3 commits into from
Jun 22, 2022

Conversation

JuliaKukulies
Copy link
Member

Added a pull request check list that automatically will appear in the pull request description field. Please feel free to add any checks that I have missed or remove redundant instructions. I have put the file here to not overpopulate the root directory. We could, however also move it to doc/

@JuliaKukulies JuliaKukulies changed the title added pull_request_template in .github/ added pull_request_template.md in .github/ Apr 13, 2022
@JuliaKukulies JuliaKukulies force-pushed the dev-ops branch 2 times, most recently from ac10568 to d5eefd0 Compare April 13, 2022 16:21
@JuliaKukulies
Copy link
Member Author

This should of course go into dev, sorry for the mess. I rebased my branch onto dev, but can still not change it the target branch here.

@fsenf fsenf added this to the Version 1.5 milestone Apr 14, 2022
@freemansw1 freemansw1 changed the base branch from main to dev April 14, 2022 22:30
@freemansw1
Copy link
Member

I was able to change the target branch to dev.

.github/pull_request_template.md Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
Copy link
Member

@freemansw1 freemansw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with these now, thanks!

@freemansw1 freemansw1 added the enhancement Addition of new features, or improved functionality of existing features label Apr 27, 2022
@freemansw1
Copy link
Member

I am inclined for us to go ahead and merge this unless you have objection @JuliaKukulies

@JuliaKukulies
Copy link
Member Author

Please go ahead @freemansw1

@freemansw1 freemansw1 modified the milestones: Version 1.5, Version 1.3.1 Jun 22, 2022
@freemansw1 freemansw1 merged commit 5fb4071 into tobac-project:dev Jun 22, 2022
freemansw1 added a commit to freemansw1/tobac that referenced this pull request Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Addition of new features, or improved functionality of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants