This repository has been archived by the owner on May 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
w-k-jones
reviewed
Feb 12, 2023
tutorials/Example_Track_on_Radar_Segment_on_Satellite/track_on_radar_segment_on_satellite.ipynb
Show resolved
Hide resolved
w-k-jones
reviewed
Feb 12, 2023
tutorials/Example_Track_on_Radar_Segment_on_Satellite/track_on_radar_segment_on_satellite.ipynb
Show resolved
Hide resolved
w-k-jones
reviewed
Feb 12, 2023
tutorials/Example_Track_on_Radar_Segment_on_Satellite/track_on_radar_segment_on_satellite.ipynb
Show resolved
Hide resolved
w-k-jones
reviewed
Feb 12, 2023
tutorials/Example_Track_on_Radar_Segment_on_Satellite/track_on_radar_segment_on_satellite.ipynb
Show resolved
Hide resolved
w-k-jones
reviewed
Feb 12, 2023
tutorials/Example_Track_on_Radar_Segment_on_Satellite/track_on_radar_segment_on_satellite.ipynb
Show resolved
Hide resolved
w-k-jones
reviewed
Feb 12, 2023
tutorials/Example_Track_on_Radar_Segment_on_Satellite/track_on_radar_segment_on_satellite.ipynb
Show resolved
Hide resolved
w-k-jones
reviewed
Feb 12, 2023
tutorials/Example_Track_on_Radar_Segment_on_Satellite/track_on_radar_segment_on_satellite.ipynb
Show resolved
Hide resolved
w-k-jones
reviewed
Feb 12, 2023
tutorials/Example_Track_on_Radar_Segment_on_Satellite/track_on_radar_segment_on_satellite.ipynb
Show resolved
Hide resolved
w-k-jones
reviewed
Feb 12, 2023
tutorials/Example_Track_on_Radar_Segment_on_Satellite/track_on_radar_segment_on_satellite.ipynb
Show resolved
Hide resolved
w-k-jones
suggested changes
Feb 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nice example overall, but I think a couple of changes would make it more approachable for users:
- Make it more consistent with the existing examples, particularly variable naming
- Rearrange into clear sections with documentation in markdown cells. In particular, separating the data processing for nexrad and goes would improve clarity
- Increase the time period so that it encompasses multiple goes files to demonstrate how features are mapped in time as well as space
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What kind of change does this PR introduce?
A tutorial showing how to use the new transform points for segmentation feature introduced in Adding ability to track on one dataset, segment on another tobac#242 .
What is the current behavior? (You can also link to an open issue here)
n/a
What is the new behavior (if this applies) or the new content?
An example notebook showing feature detection on a radar grid and segmentation on a satellite grid.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Note that this PR uses the tobac v1.x style, rather than v2.0_dev.
I should note that this tutorial notebook could be improved with more markdown, but I wanted to get something in for the main tobac PR.
Checklist for Requirements
General
Style
index.rst
file?Data & Reproducibility
Concerning Tests
Git Aspects: To Make It Easier for Us!