Get by id creates empty predicate. #314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… all providers. Predicate is not filled out when using Get(value) but they work when using Get(object). I noticed that in `DapperImplementor.GetMapAndPredicate`, GetKeyPredicate is only called for Update and Delete, not Get.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case on master currently works because there is only 1 row in the database, so select without a where returns 1 row as expected.
Added breaking test case for SQL Server Get, though this bug may affect all providers.
The predicate is not filled out when using Get(value) but they work when using Get(object). I noticed that in
DapperImplementor.GetMapAndPredicate, GetKeyPredicate is only called for Update and Delete, not Get.This pull request does not fix anything, it will start to fail the build because this is a bug.
Workaround for developers trying to use Get is to use Get(new {}) syntax.
Workaround for Dapper-Extensions is to fix the documentation to say Get(new { id }) instead of Get(id).