Don't import SMS messages with multiple recipients

Addresses: #159
tmo1 · Mar 1, 2024 · 2f07074 · 2f07074
1 parent 3bb6f17
commit 2f07074
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/README.md b/README.md
@@ -247,6 +247,10 @@ java.lang.IllegalArgumentException: The non-sync-callers AND non-blocked-url sho
 ```
 For a possible solution, see [here](https://github.com/tmo1/sms-ie/issues/103#issuecomment-1620890135).
 
+#### SMS Messages With Multiple Recipients
+
+SMS messages with multiple recipients are currently not handled entirely correctly; see [issue #159](https://github.com/tmo1/sms-ie/issues/159) for details and the current status of support for such messages.
+
 ## Translations
 
 SMS Import / Export has been translated (from the original English) into the following languages (note that some of these translations may contain inaccuracies, due to changes to the app's original text since they were made):

diff --git a/app/src/main/java/com/github/tmo1/sms_ie/ImportExportMessages.kt b/app/src/main/java/com/github/tmo1/sms_ie/ImportExportMessages.kt
@@ -388,6 +388,12 @@ suspend fun importMessages(
                                         Log.d(LOG_TAG, "Skipping due to debug settings")
                                         return@JSONLine
                                     }
+                                    // I haven't been able to figure out how to properly insert SMS messages with multiple recipients
+                                    // https://github.com/tmo1/sms-ie/issues/159
+                                    if (messageJSON.optString(Telephony.Sms.ADDRESS).split(" ").size > 1) {
+                                        Log.d(LOG_TAG, "SMS has multiple recipients - skipping")
+                                        return@JSONLine
+                                    }
                                     if (deduplication) {
                                         val smsDuplicatesCursor = appContext.contentResolver.query(
                                             Telephony.Sms.CONTENT_URI,