Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle updated field name #2

Merged
merged 1 commit into from
Dec 5, 2021
Merged

Handle updated field name #2

merged 1 commit into from
Dec 5, 2021

Conversation

log-linear
Copy link
Contributor

@log-linear log-linear commented Oct 28, 2021

recipient_ids field appears to have been renamed thread_recipient_id. The script would not run for me until I made the update. As a side note, this script can also export Signal's encrypted chats, but not images sent through encrypted messages.

`recipient_ids` field appears to have been renamed `thread_recipient_id`
@tmo1
Copy link
Owner

tmo1 commented Oct 29, 2021

recipient_ids field appears to have been renamed thread_recipient_id. The script would not run for me until I made the update.

Thanks for catching this and bringing it to my attention! I would like to preserve backward compatibility with older Signal backups, so I think we should use some sort of test to handle both possibilities.

As a side note, this script can also export Signal's encrypted chats, but not images sent through encrypted messages.

Good to know. As I noted in the README:

My Signal databases contain only ordinary SMS and MMS messages, and not Signal's end-to-end encrypted messages, so I do not know whether sms-db will properly import such messages.

So now we know ;) Perhaps in the future I can work on that - in the meantime, patches welcome!

@tmo1
Copy link
Owner

tmo1 commented Dec 5, 2021

On second thought, I think your way is preferable: try to keep sms-db compatible with the current Signal database format, and instruct the user to update the Signal backup to the current format (by installing the current version of the Signal app and having it do the migration by restoring from the backup and then creating a new backing in the current format).

For what it's worth, Signal's migration code has the details of what changes to the database format were made in each version bump; it looks like this one was made in version 108 ("THREAD_AUTOINCREMENT").

@tmo1 tmo1 merged commit 62cb5af into tmo1:main Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants